Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEP-400 ui: 다크모드 지원하지 않도록 수정 #208

Merged
merged 1 commit into from
Mar 4, 2023
Merged

DEP-400 ui: 다크모드 지원하지 않도록 수정 #208

merged 1 commit into from
Mar 4, 2023

Conversation

juhwankim-dev
Copy link
Member

💁‍♂️ 변경 내용

AS-IS

  • 다크모드로 앱에 접속하면 흰색이 검은색으로 보이고 action bar도 그대로 보였습니다.

TO-BE

  • 다크모드를 지원하지 않게 하였습니다. (= 다크모드 선택 시 라이트모드처럼 보이게 함. 다크모드에서 action bar 없앰)

@juhwankim-dev juhwankim-dev self-assigned this Mar 2, 2023
@juhwankim-dev juhwankim-dev requested a review from a team as a code owner March 2, 2023 17:09
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@junhaesung
Copy link
Member

다크모드에서 테스트 한 번 부탁드립니다-

@juhwankim-dev
Copy link
Member Author

다크모드에서 테스트 한 번 부탁드립니다-

다크모드에서 테스트 한 번 부탁드립니다-

확인했습니다 ~!

@juhwankim-dev juhwankim-dev merged commit dfb9c0d into develop Mar 4, 2023
@juhwankim-dev juhwankim-dev deleted the feature/DEP-400_dark_mode branch March 4, 2023 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junhaesung junhaesung junhaesung approved these changes

Assignees

@juhwankim-dev juhwankim-dev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juhwankim-dev @junhaesung