Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEP-401 fix: 인디케이터를 이동 방식 -> 채워가는 방식으로 변경 #209

Merged
merged 1 commit into from
Mar 4, 2023
Merged

DEP-401 fix: 인디케이터를 이동 방식 -> 채워가는 방식으로 변경 #209

merged 1 commit into from
Mar 4, 2023

Conversation

juhwankim-dev
Copy link
Member

💁‍♂️ 변경 내용

image
image

AS-IS

  • 온보딩 인디케이터가 페이지 이동할 때마다 같이 이동하는 방식이였습니다.

TO-BE

  • 인디케이터가 채워지는 방식으로 변경했습니다.

@juhwankim-dev juhwankim-dev requested a review from a team as a code owner March 2, 2023 17:17
@juhwankim-dev juhwankim-dev self-assigned this Mar 2, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@juhwankim-dev juhwankim-dev merged commit 4878def into develop Mar 4, 2023
@juhwankim-dev juhwankim-dev deleted the feature/DEP-401 branch March 4, 2023 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junhaesung junhaesung junhaesung approved these changes

Assignees

@juhwankim-dev juhwankim-dev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juhwankim-dev @junhaesung