Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: switch to NPM workspaces #687

Merged
merged 11 commits into from
Sep 18, 2023
Merged

refactor: switch to NPM workspaces #687

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
248f60e
redo from develop
straker Sep 6, 2023
5a00166
pin to axe-core 4.7.2
straker Sep 6, 2023
1427554
pin to webdriverio 8.8.2
straker Sep 6, 2023
4569f12
debug
straker Sep 11, 2023
4ab05d8
remove timeout
straker Sep 11, 2023
52c2049
pin to puppeteer 19.7.3
straker Sep 11, 2023
f913a06
remove debug
straker Sep 11, 2023
2dedf1b
apply changes
straker Sep 13, 2023
faf4bbd
checkout correct tsconfig file
straker Sep 13, 2023
228d9db
Merge branch 'develop' into npm-workspaces
dbjorge Sep 14, 2023
7898c6b
update package-lock.json per steves recent changes
dbjorge Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 20 additions & 29 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ jobs:
node-version: 18
cache: 'npm'
- run: npm ci
- run: npm run bootstrap -- --ci
- run: npm run lint

puppeteer:
Expand All @@ -36,14 +35,13 @@ jobs:
node-version: ${{ matrix.node}}
cache: 'npm'
- run: npm ci
- run: npm run bootstrap -- --ci
# HACK: Force a TTY to enable browser-driver-manager to manipulate stdout.
- shell: 'script -q -e -c "bash {0}"'
run: npx browser-driver-manager install chromedriver --verbose
working-directory: packages/puppeteer
- run: npm run build --prefix=packages/puppeteer
- run: npm run coverage --prefix=packages/puppeteer
- run: npm run test:esm --prefix=packages/puppeteer
- run: npm run build --workspace=packages/puppeteer
- run: npm run coverage --workspace=packages/puppeteer
- run: npm run test:esm --workspace=packages/puppeteer

cli:
strategy:
Expand All @@ -59,7 +57,6 @@ jobs:
node-version: ${{ matrix.node }}
cache: 'npm'
- run: npm ci
- run: npm run bootstrap -- --ci
# HACK: Force a TTY to enable browser-driver-manager to manipulate stdout.
- shell: 'script -q -e -c "bash {0}"'
run: npx browser-driver-manager install chromedriver --verbose
Expand All @@ -69,7 +66,7 @@ jobs:
# lerna link after installing the latest version of chromedriver, as we depend on webdriverJS
- run: npx lerna link
working-directory: packages/cli
- run: npm run coverage --prefix=packages/cli
- run: npm run coverage --workspace=packages/cli

webdriverjs:
strategy:
Expand All @@ -85,14 +82,13 @@ jobs:
node-version: ${{ matrix.node }}
cache: 'npm'
- run: npm ci
- run: npm run bootstrap -- --ci
# HACK: Force a TTY to enable browser-driver-manager to manipulate stdout.
- shell: 'script -q -e -c "bash {0}"'
run: npx browser-driver-manager install chromedriver --verbose
working-directory: packages/webdriverjs
- run: npm run build --prefix=packages/webdriverjs
- run: npm run coverage --prefix=packages/webdriverjs
- run: npm run test:esm --prefix=packages/webdriverjs
- run: npm run build --workspace=packages/webdriverjs
- run: npm run coverage --workspace=packages/webdriverjs
- run: npm run test:esm --workspace=packages/webdriverjs

webdriverio:
strategy:
Expand All @@ -108,14 +104,13 @@ jobs:
node-version: ${{ matrix.node }}
cache: 'npm'
- run: npm ci
- run: npm run bootstrap -- --ci
# HACK: Force a TTY to enable browser-driver-manager to manipulate stdout.
- shell: 'script -q -e -c "bash {0}"'
run: npx browser-driver-manager install chromedriver --verbose
working-directory: packages/webdriverio
- run: npm run build --prefix=packages/webdriverio
- run: npm run coverage --prefix=packages/webdriverio
- run: npm run test:esm --prefix=packages/webdriverio
- run: npm run build --workspace=packages/webdriverio
- run: npm run coverage --workspace=packages/webdriverio
- run: npm run test:esm --workspace=packages/webdriverio

reporter_earl:
strategy:
Expand All @@ -131,10 +126,9 @@ jobs:
node-version: ${{ matrix.node }}
cache: 'npm'
- run: npm ci
- run: npm run bootstrap -- --ci
- run: npm run build --prefix=packages/reporter-earl
- run: npm run test --prefix=packages/reporter-earl
- run: npm run test:esm --prefix=packages/reporter-earl
- run: npm run build --workspace=packages/reporter-earl
- run: npm run test --workspace=packages/reporter-earl
- run: npm run test:esm --workspace=packages/reporter-earl

react:
strategy:
Expand All @@ -150,10 +144,9 @@ jobs:
node-version: ${{ matrix.node }}
cache: 'npm'
- run: npm ci
- run: npm run bootstrap -- --ci
- run: npm run build --prefix=packages/react
- run: npm run test --prefix=packages/react
- run: npm run test:esm --prefix=packages/react
- run: npm run build --workspace=packages/react
- run: npm run test --workspace=packages/react
- run: npm run test:esm --workspace=packages/react

playwright:
strategy:
Expand All @@ -169,11 +162,10 @@ jobs:
node-version: ${{ matrix.node }}
cache: 'npm'
- run: npm ci
- run: npm run bootstrap -- --ci
- run: npx playwright install --with-deps
- run: npm run build --prefix=packages/playwright
- run: npm run coverage --prefix=packages/playwright
- run: npm run test:esm --prefix=packages/playwright
- run: npm run build --workspace=packages/playwright
- run: npm run coverage --workspace=packages/playwright
- run: npm run test:esm --workspace=packages/playwright

axe_core_test:
if: github.ref_name == 'master' || startsWith(github.ref_name, 'release')
Expand All @@ -187,5 +179,4 @@ jobs:
node-version: 18
cache: 'npm'
- run: npm ci
- run: npm run bootstrap -- --ci
- run: npm test --prefix=test/axe-core
- run: npm test --workspace=test/axe-core
7 changes: 1 addition & 6 deletions lerna.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,4 @@
{
"packages": [
"packages/*",
"packages/react/examples/*",
"packages/webdriverjs/tests/example",
"test/axe-core"
],
"useWorkspaces": true,
"version": "4.7.3"
}
Loading