ci: ensure tests use newly installed chromedriver and not chromedriver from node_modules
#794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zidious
changed the title
node_modules
Zidious
changed the title
node_modulesnode_modules
…quelabs/axe-core-npm into ci-use-browser-driver-manager
straker
approved these changes
Aug 22, 2023
This was referenced Aug 24, 2023
This was referenced Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes our broken CI tests relating to chromedriver. It was consuming the chromedriver version from
node_modules(webdriverjs and webdriverio) which will likely always be out of date. Instead we usebrowser-driver-managerto update to the latest chromedriver to run tests, however it was not being respected. This was because it was being installed on the root, not the working directory, now we specify a working directory where we install browser manager.