Skip to content

Commit

Permalink
fix(label): pass when role none or presentation (#2464)
Browse files Browse the repository at this point in the history
Pass label rule when role none or presentation

Closes #2458
  • Loading branch information
42tte authored and straker committed Sep 8, 2020
1 parent 01b1eb3 commit 1d3c2fc
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 1 deletion.
4 changes: 3 additions & 1 deletion lib/rules/label.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@
"aria-labelledby",
"implicit-label",
"explicit-label",
"non-empty-title"
"non-empty-title",
"role-none",
"role-presentation"
],
"none": ["help-same-as-label", "hidden-explicit-label"]
}
3 changes: 3 additions & 0 deletions test/integration/rules/label/label.html
Original file line number Diff line number Diff line change
Expand Up @@ -73,4 +73,7 @@
</label>
<input id="pass-gh1176" title="Hi" />
</div>

<input id="pass16" role="none" disabled />
<input id="pass17" role="presentation" disabled />
</form>
2 changes: 2 additions & 0 deletions test/integration/rules/label/label.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@
["#pass13"],
["#pass14"],
["#pass15"],
["#pass16"],
["#pass17"],
["#pass-gh1176"]
]
}

0 comments on commit 1d3c2fc

Please sign in to comment.