Apply suggestions from code review

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
dequelabs · Jul 14, 2023 · 236d27a · 236d27a
1 parent 4705e2a
commit 236d27a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/test/integration/rules/aria-allowed-attr/passes.html b/test/integration/rules/aria-allowed-attr/passes.html
@@ -2154,6 +2154,7 @@
 <input type="checkbox" aria-checked="false" id="pass92" />
 <input type="checkbox" aria-checked="true" checked id="pass93" />
 
+<!-- Prohibited attributes fail in aria-prohibited-attr -->
 <div role="caption" aria-label="value" id="pass94"></div>
 <div role="caption" aria-labelledby="value" id="pass95"></div>
 <div role="paragraph" aria-labelledby="value" id="pass96"></div>

diff --git a/test/integration/rules/aria-prohibited-attr/aria-prohibited-attr.html b/test/integration/rules/aria-prohibited-attr/aria-prohibited-attr.html
@@ -24,7 +24,8 @@
 <div role="superscript" aria-labelledby="value" id="fail18"></div>
 <div aria-label="value" id="fail19"></div>
 <div aria-labelledby="value" id="fail20"></div>
-<!-- technically presentation and none roles do not allow aria-label and aria-labelledby, but since those are global attributes the presentation role conflict will not resolve the roles to none or presentation -->
+<!- aria-label(ledby) is prohibited on none / presentation. Axe-core considers this to trigger presentation role 
+conflict, which was true in ARIA 1.1. This changed in ARIA 1.2 but so far has only been implemented in Chomium. -->
 <span aria-label="value" id="fail21"></span>
 <strong aria-label="value" id="fail22"></strong>
 <kbd aria-label="value" id="fail23"></kbd>