fix(link-name): fix regression where link was not named from title at…

…tribute (#2492)
dequelabs · Aug 27, 2020 · 378a5f0 · 378a5f0
1 parent 32888d4
commit 378a5f0
Show file tree

Hide file tree

Showing 4 changed files with 48 additions and 2 deletions.
diff --git a/lib/rules/link-name.json b/lib/rules/link-name.json
@@ -19,7 +19,8 @@
 		"aria-label",
 		"aria-labelledby",
 		"role-presentation",
-		"role-none"
+		"role-none",
+		"non-empty-title"
 	],
 	"none": ["focusable-no-name"]
 }
diff --git a/test/integration/rules/link-name/link-name.html b/test/integration/rules/link-name/link-name.html
@@ -36,4 +36,7 @@
 	aria-labelledby="nonexistent"
 ></span>
 
+<a href="#" id="pass8" title="title text"></a>
+<span role="link" href="#" tabindex="0" id="pass9" title="title text"></span>
+
 <a href="#" role="button">Does not apply</a>
diff --git a/test/integration/rules/link-name/link-name.json b/test/integration/rules/link-name/link-name.json
@@ -9,5 +9,13 @@
 		["#violation5"],
 		["#violation6"]
 	],
-	"passes": [["#pass1"], ["#pass3"], ["#pass4"], ["#pass6"], ["#pass7"]]
+	"passes": [
+		["#pass1"],
+		["#pass3"],
+		["#pass4"],
+		["#pass6"],
+		["#pass7"],
+		["#pass8"],
+		["#pass9"]
+	]
 }
diff --git a/test/integration/virtual-rules/link-name.js b/test/integration/virtual-rules/link-name.js
@@ -88,6 +88,23 @@ describe('link-name', function() {
 		assert.lengthOf(results.incomplete, 0);
 	});
 
+	it('should pass for title', function() {
+		var node = new axe.SerialVirtualNode({
+			nodeName: 'a',
+			attributes: {
+				href: '/foo.html',
+				title: 'foobar'
+			}
+		});
+		node.children = [];
+
+		var results = axe.runVirtualRule('link-name', node);
+
+		assert.lengthOf(results.passes, 1);
+		assert.lengthOf(results.violations, 0);
+		assert.lengthOf(results.incomplete, 0);
+	});
+
 	it('should incomplete when aria-label and children are missing', function() {
 		var node = new axe.SerialVirtualNode({
 			nodeName: 'a',
@@ -169,4 +186,21 @@ describe('link-name', function() {
 		assert.lengthOf(results.violations, 1);
 		assert.lengthOf(results.incomplete, 0);
 	});
+
+	it('should fail when title is empty', function() {
+		var node = new axe.SerialVirtualNode({
+			nodeName: 'a',
+			attributes: {
+				href: '/foo.html',
+				title: ''
+			}
+		});
+		node.children = [];
+
+		var results = axe.runVirtualRule('link-name', node);
+
+		assert.lengthOf(results.passes, 0);
+		assert.lengthOf(results.violations, 1);
+		assert.lengthOf(results.incomplete, 0);
+	});
 });