Skip to content

Commit

Permalink
fix(all-rules): fix flakey all-rules firefox test (#4467)
Browse files Browse the repository at this point in the history
wilco and I believe marque is to blame because it is animated


This fixes the `all-rules` check, particularly on Firefox. We believe
the issue is because marque has a moving bounding client rect, leading
to inconsistent results. So instead we set the motion to none for a
consistent testing environment.

---

To see that it works, I've run the CI tests on this branch five times.
It only failed on one unrelated flakey test this does not address.

Also, #4456 finally builds
after many consistent test failures in the same place in a row after
rebasing on this change.

We can see this test failing on other branches, such as `develop` in
places like this:
https://app.circleci.com/pipelines/github/dequelabs/axe-core/6332/workflows/b3e2a293-c89b-4201-898d-1c6c64ee2764
which shows it has nothing to do with the other PR.
  • Loading branch information
gaiety-deque authored May 20, 2024
1 parent f584e8e commit 3f13aa1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/integration/full/all-rules/all-rules.html
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ <h2>Ok</h2>
<p tabindex="-1">Paragraph.</p>
<input type="button" />
<input type="image" src="img.jpg" />
<marquee>This content is inside a marquee.</marquee>
<marquee scrollamount="0">This content is inside a marquee.</marquee>
<div role="navigation">
<div role="banner"></div>
<div role="complementary"></div>
Expand Down

0 comments on commit 3f13aa1

Please sign in to comment.