refactor(checks/unsupportedrole): change this.data from using array t…

…o single string
dequelabs · Feb 27, 2022 · 4bbd863 · 4bbd863
1 parent 840a581
commit 4bbd863
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/lib/checks/aria/unsupportedrole-evaluate.js b/lib/checks/aria/unsupportedrole-evaluate.js
@@ -12,7 +12,7 @@ function unsupportedroleEvaluate(node, options, virtualNode) {
   const role = getRole(virtualNode, { dpub: true, fallback: true });
   const isUnsupported = isUnsupportedRole(role);
   if (isUnsupported) {
-    this.data([role]);
+    this.data(role);
   }
   return isUnsupported;
 

diff --git a/lib/checks/aria/unsupportedrole.json b/lib/checks/aria/unsupportedrole.json
@@ -5,7 +5,7 @@
     "impact": "critical",
     "messages": {
       "pass": "ARIA role is supported",
-      "fail": "The role used is not widely supported in screen readers and assistive technologies: ${data.values}"
+      "fail": "The role used is not widely supported in screen readers and assistive technologies: ${data}"
     }
   }
 }
diff --git a/test/checks/aria/unsupportedrole.js b/test/checks/aria/unsupportedrole.js
@@ -25,7 +25,7 @@ describe('unsupportedrole', function() {
       '<div id="target" role="mccheddarton">Contents</div>'
     );
     assert.isTrue(check.evaluate.apply(checkContext, params));
-    assert.deepEqual(checkContext._data, ["mccheddarton"]);
+    assert.deepEqual(checkContext._data, "mccheddarton");
   });
 
   it('should return false if applied to a supported role', function() {
@@ -60,7 +60,7 @@ describe('unsupportedrole', function() {
       '<div id="target" role="doc-abstract">Contents</div>'
     );
     assert.isTrue(check.evaluate.apply(checkContext, params));
-    assert.deepEqual(checkContext._data, ["doc-abstract"]);
+    assert.deepEqual(checkContext._data, "doc-abstract");
   });
 
   it('should return true if applied to an unsupported fallback role', function() {
@@ -79,7 +79,7 @@ describe('unsupportedrole', function() {
       '<div id="target" role="unsupported alert">Contents</div>'
     );
     assert.isTrue(check.evaluate.apply(checkContext, params));
-    assert.deepEqual(checkContext._data, ["alert"]);
+    assert.deepEqual(checkContext._data, "alert");
   });
 
 });