Skip to content

Commit

Permalink
fix(aria-allowed-attr): allow aria-required on role=slider (#4035)
Browse files Browse the repository at this point in the history
  • Loading branch information
straker authored May 24, 2023
1 parent 25859dd commit bb2bf60
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
3 changes: 3 additions & 0 deletions lib/standards/aria-roles.js
Original file line number Diff line number Diff line change
Expand Up @@ -631,11 +631,14 @@ const ariaRoles = {
// Note: since the slider role has implicit
// aria-orientation, aria-valuemax, aria-valuemin values it
// is not required to be added by the user
// Note: aria-required is not in the 1.1 or 1.2 specs but is
// consistently supported in ATs
allowedAttrs: [
'aria-valuemax',
'aria-valuemin',
'aria-orientation',
'aria-readonly',
'aria-required',
'aria-valuetext'
],
superclassRole: ['input', 'range'],
Expand Down
1 change: 1 addition & 0 deletions test/integration/rules/aria-allowed-attr/passes.html
Original file line number Diff line number Diff line change
Expand Up @@ -1509,6 +1509,7 @@
aria-owns="value"
aria-relevant="value"
aria-readonly="value"
aria-required="value"
>
ok
</div>
Expand Down

0 comments on commit bb2bf60

Please sign in to comment.