refactor(title-only-evaluate): work with virtual nodes (#2489)

dequelabs · Sep 8, 2020 · ed6fa45 · ed6fa45
1 parent 7894d76
commit ed6fa45
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/lib/checks/label/title-only-evaluate.js b/lib/checks/label/title-only-evaluate.js
@@ -1,11 +1,11 @@
-import { labelVirtual } from '../../commons/text';
+import { labelVirtual, titleText } from '../../commons/text';
 
 function titleOnlyEvaluate(node, options, virtualNode) {
-	var labelText = labelVirtual(virtualNode);
-	return (
-		!labelText &&
-		!!(node.getAttribute('title') || node.getAttribute('aria-describedby'))
-	);
+	const labelText = labelVirtual(virtualNode);
+	const title = titleText(virtualNode);
+	const ariaDescribedBy = virtualNode.attr('aria-describedby');
+
+	return !labelText && !!(title || ariaDescribedBy);
 }
 
 export default titleOnlyEvaluate;