Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positives when using aria-roledescription #3649

Closed
1 task done
tesk9 opened this issue Sep 7, 2022 · 4 comments · Fixed by #3948
Closed
1 task done

False positives when using aria-roledescription #3649

tesk9 opened this issue Sep 7, 2022 · 4 comments · Fixed by #3948
Labels
info needed More information or research is needed to continue pr A pr has been created for the issue
Milestone
Axe-core 4.7

Comments

@tesk9
Copy link

tesk9 commented Sep 7, 2022

Product

axe-core

Product Version

4.4.3

Latest Version

  • I have tested the issue with the latest version of the product

Issue Description

Expectation

aria-roledescription should be allowed on any element that has "a valid WAI-ARIA role or has an implicit WAI-ARIA role," according to ARIA 1.1's roledescription section

Actual

I believe that the checks for aria-roledescription limit the supported WAI-ARIA roles to:

"supportedRoles": [
      "button",
      "img",
      "checkbox",
      "radio",
      "combobox",
      "menuitemcheckbox",
      "menuitemradio"
    ]

which leaves out a fair number of roles, including the "region" role that's used in the ARIA 1.1. example of a "slide".

How to Reproduce

Provide a code sample or link to a webpage that reproduces the issue. Without this, your issue may be closed without investigation.

Add the following HTML node to a page:
<mark aria-roledescription="Claim highlight">Bats are vital pollinators</mark>

Run axe devtools or any of the other tools that use axe-core, and you'll get an error:
Screen Shot of axe devtools output with Issue 'Ensure aria-roledescription is only used on elements with an implicit or explicit role' highlighting `mark[aria-roledescription='Claim highlight']`
@tesk9 tesk9 added the ungroomed Ticket needs a maintainer to prioritize and label label Sep 7, 2022
@tesk9 tesk9 mentioned this issue Sep 7, 2022
Merged
@straker
Copy link
Contributor

straker commented Sep 8, 2022

Thanks for the issue. When we created the check two years ago, assistive technologies didn't support it very well for non-interactive elements. That may have changed in the past years, so we can recheck support.

@straker straker added info needed More information or research is needed to continue and removed ungroomed Ticket needs a maintainer to prioritize and label labels Sep 8, 2022
@WilcoFiers WilcoFiers modified the milestones: Axe-core 4.7, Axe-core 4.6 Nov 30, 2022
@WilcoFiers WilcoFiers mentioned this issue Jan 27, 2023
Closed
@straker straker mentioned this issue Mar 20, 2023
Merged
@straker
Copy link
Contributor

straker commented Mar 20, 2023

After rechecking, the attribute is fully supported so we'll disable the rule and deprecate it..

@tesk9
Copy link
Author

tesk9 commented Mar 20, 2023

Thanks!

@straker straker added the pr A pr has been created for the issue label Mar 20, 2023
@padmavemulapati
Copy link

Validated with the latest axe-core develop branch code base, aria-roledescription is deprecated , so that with the latest axe.run is not showing aria-roledescription with the below code snippet:

 <p aria-roledescription="my paragraph" id="fail1">paragraph</p>
<div aria-roledescription="my div" id="fail2">div</div>
<div
  role="presentation"
  aria-roledescription="my presentation"
  id="fail3"
></div>
<div role="none" aria-roledescription="my none" id="fail4"></div>

Where with the earlier axe version (let us 4.6.3 production version) we can see the failure for aria-roledescription

Image

@codeofdusk codeofdusk mentioned this issue Jul 29, 2023
Merged
3 tasks
codeofdusk added a commit to microsoft/accessibility-insights-web that referenced this issue Aug 1, 2023
@codeofdusk
feat(axe-core-4.7): Bump axe.core version to 4.7.2, exclude aria-role…
165b933 
…description, and promote scrollable-region-focusable (#6849)

This commit updates axe-core to its latest version, 4.7.2, from
4.6.3. It also
bumps the accessibility-insights-report package version. As part of the
axe-core update:

* The `aria-roledescription` rule has been deprecated
(dequelabs/axe-core#3649).
* `scrollable-region-focusable` axe-core rule failures have been
promoted from "needs review" to "serious" (manually removed from
explicit "needs review" but included automatically by axe-core), see
dequelabs/axe-core#3862 and dequelabs/axe-core#3939.
* `falsePositiveRemoval` introduced in
ed75fda has been removed as the
corresponding dequelabs/axe-core#3850 has been resolved.

Part of Feature 2086120 (internal access required to view).
@scottaohara scottaohara mentioned this issue Aug 1, 2023
Open
@v-sharmachir v-sharmachir mentioned this issue Nov 18, 2024
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
info needed More information or research is needed to continue pr A pr has been created for the issue
Projects
None yet
Milestone
Axe-core 4.7
Development

Successfully merging a pull request may close this issue.

feat(aria-roledescription): deprecate and disable rule dequelabs/axe-core
4 participants
@WilcoFiers @straker @tesk9 @padmavemulapati