Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected error raised for table marked as presentation #3654

Closed
1 task done
scottaohara opened this issue Sep 8, 2022 · 2 comments
Closed
1 task done

Unexpected error raised for table marked as presentation #3654

scottaohara opened this issue Sep 8, 2022 · 2 comments
Assignees
Labels
fix Bug fixes pr A pr has been created for the issue rules Issue or false result from an axe-core rule
Milestone

Comments

@scottaohara
Copy link
Contributor

Product

axe-core

Product Version

4.4.2

Latest Version

  • I have tested the issue with the latest version of the product

Issue Description

The following code snippet was flagged as a serious error with axe for use of the headers attribute.

<table role=presentation>
 <tr><th hidden>...</th><th>...</th></tr>
  <tr>
     <td headers=foo hidden>...</td>
     <td>...</td>
  </tr>
</table>

However, this doesn't make any sense to flag as an error because:

  1. the table has been marked as role=presentation so table semantics are kicked to the curb anyway.
  2. the cell with the erroneous headers attribute on it also has the hidden attribute, so even if the table was still exposed as a table, the cell is hidden so still can't be an accessibility issue.
@scottaohara scottaohara added the ungroomed Ticket needs a maintainer to prioritize and label label Sep 8, 2022
@WilcoFiers
Copy link
Contributor

Thanks for the report @scottaohara. I agree with you, tables with role=presentation shouldn't match the td-headers-attr rule.

@WilcoFiers WilcoFiers added fix Bug fixes rules Issue or false result from an axe-core rule and removed ungroomed Ticket needs a maintainer to prioritize and label labels Sep 12, 2022
@WilcoFiers WilcoFiers added this to the Axe-core 4.5 milestone Sep 12, 2022
@WilcoFiers WilcoFiers self-assigned this Sep 27, 2022
@WilcoFiers WilcoFiers added the pr A pr has been created for the issue label Sep 27, 2022
@padmavemulapati
Copy link

Valdiated with the latest axe-core develop branch code base,
in the test script table has been marked as role=presentation and td atrribute as hidden so test snippet should not fail for td-headers-attr rule

<table role=presentation>
 <tr><th hidden>...</th><th>...</th></tr>
  <tr>
     <td headers=foo hidden>...</td>
     <td>...</td>
  </tr>
</table>

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fixes pr A pr has been created for the issue rules Issue or false result from an axe-core rule
Projects
None yet
Development

No branches or pull requests

3 participants