Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(td-headers-attr): ignore hidden cells with headers attr #3684

Merged
merged 3 commits into from
Sep 28, 2022
Merged

fix(td-headers-attr): ignore hidden cells with headers attr #3684

merged 3 commits into from
Sep 28, 2022

Conversation

WilcoFiers
Copy link
Contributor

  • Only test tables with an implicit or explicit role of table, grid, or treegrid
  • Ignore hidden cells with a headers attribute
  • Add integration tests

Closes issue: #3654

@WilcoFiers WilcoFiers requested a review from a team as a code owner September 27, 2022 11:16
@WilcoFiers WilcoFiers changed the title fix(td-headers-attr): ignore table elements with their role changed fix(td-headers-attr): ignore hidden cells with headers attr Sep 28, 2022
@WilcoFiers WilcoFiers marked this pull request as draft September 28, 2022 09:23
@WilcoFiers WilcoFiers requested a review from straker September 28, 2022 09:23
@WilcoFiers WilcoFiers marked this pull request as ready for review September 28, 2022 13:49
@WilcoFiers WilcoFiers merged commit e0403f4 into develop Sep 28, 2022
@WilcoFiers WilcoFiers deleted the presentational-tables branch September 28, 2022 16:10
@Shubhabrata08 Shubhabrata08 mentioned this pull request Jan 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straker straker straker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WilcoFiers @straker