Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add required contrast in color-contrast message #381

Closed
WilcoFiers opened this issue Jun 26, 2017 · 5 comments
Closed

Add required contrast in color-contrast message #381

WilcoFiers opened this issue Jun 26, 2017 · 5 comments
Labels
color contrast Color contrast issues rules Issue or false result from an axe-core rule

Comments

@WilcoFiers
Copy link
Contributor

The color contrast message is as follows:

"Element has insufficient color contrast of {{=it.data.contrastRatio}} (foreground color: {{=it.data.fgColor}}, background color: {{=it.data.bgColor}}, font size: {{=it.data.fontSize}}, font weight: {{=it.data.fontWeight}})",

It would be better if this would include what contrast ratio was required (4.5:1 or 3:1).
@tealamore
Copy link
Contributor

Are you all wanting a PR to fix this?

@WilcoFiers
Copy link
Contributor Author

If you've got one, or a little time to create it, you bet!

@tealamore
Copy link
Contributor

Ok. So I've been looking into this. How do I go about testing that the data is properly being displayed in the message?

@WilcoFiers
Copy link
Contributor Author

You can run grunt dev which will start a server, and play around with some code in test/playground.html.

@marcysutton marcysutton added rules Issue or false result from an axe-core rule color contrast Color contrast issues labels Sep 28, 2017
WilcoFiers pushed a commit that referenced this issue Oct 18, 2017
@WilcoFiers
fix: Added message about expected contrast ratio (#381) (#562)
9e30d64
@WilcoFiers
Copy link
Contributor Author

Issue resolved in #562

marcysutton pushed a commit that referenced this issue Dec 11, 2017
fix: Added message about expected contrast ratio (#381) (#562)
1368c36
marcysutton pushed a commit that referenced this issue Dec 12, 2017
@marcysutton
fix: Added message about expected contrast ratio (#381) (#562)
a34c023
@dependencies dependencies bot mentioned this issue Dec 19, 2017
Merged
mrtnvh pushed a commit to mrtnvh/axe-core that referenced this issue Nov 24, 2023
@michael-siek
Merge pull request dequelabs#381 from dequelabs/master
21a2e9e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
color contrast Color contrast issues rules Issue or false result from an axe-core rule
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@WilcoFiers @marcysutton @tealamore