Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aria-prohibited-attr): add rule aria-prohibited-attr #4088

Merged
merged 4 commits into from
Jul 14, 2023
Merged

feat(aria-prohibited-attr): add rule aria-prohibited-attr #4088

merged 4 commits into from
Jul 14, 2023

Conversation

straker
Copy link
Contributor

@straker straker commented Jul 12, 2023

Closes: #4067

@straker straker requested a review from a team as a code owner July 12, 2023 23:14
WilcoFiers
WilcoFiers previously requested changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor

test/integration/rules/aria-allowed-attr/failures.html Outdated Show resolved Hide resolved
WilcoFiers
WilcoFiers previously approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 2 suggestions for you, if you want them.

test/integration/rules/aria-allowed-attr/passes.html Show resolved Hide resolved
test/integration/rules/aria-prohibited-attr/aria-prohibited-attr.html Outdated Show resolved Hide resolved
@straker @WilcoFiers
Apply suggestions from code review
236d27a 
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
@straker straker merged commit 7b115d3 into develop Jul 14, 2023
@straker straker deleted the aria-prohibited-attr branch July 14, 2023 16:41
@attest-team-ci attest-team-ci mentioned this pull request Sep 6, 2023
Merged
@abdulrahman305 abdulrahman305 mentioned this pull request Jul 3, 2024
Open
@Stanislav1975 Stanislav1975 mentioned this pull request Aug 9, 2024
Open
@Stanislav1975 Stanislav1975 mentioned this pull request Aug 19, 2024
Open
@organich organich mentioned this pull request Sep 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Put aria-prohibited-attr (from aria-allowed-attr) into its own rule
2 participants
@straker @WilcoFiers