Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule: 'region' - <section> element with non-empty 'aria-label' or 'aria-labelledby' or 'title' attributes is not being detected as a landmark #640

Closed
iamrafan opened this issue Dec 13, 2017 · 1 comment · Fixed by #642
Labels

Comments

@iamrafan
Copy link
Contributor

iamrafan commented Dec 13, 2017

<section aria-label="name1">
        <h1>Section-1: With aria-label</h1>
        <p>Content 1: Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et
            dolore magna aliqua</p>
    </section>

    <section aria-labelledby="name2">
        <h1 id="name2">Section-2: With aria-labelledby</h1>
        <p>Content 2: Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat</p>
    </section>

    <section title="name3">
        <h1>Section-3: With title</h1>
        <p>Content 3: Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur</p>
    </section>
@iamrafan iamrafan changed the title Rule: 'region' - <section> element with non-empty 'aria-label' or 'aria-labelledby' or 'title' attributes is not being detected as a 'region' landmark Rule: 'region' - <section> element with non-empty 'aria-label' or 'aria-labelledby' or 'title' attributes is not being detected as a landmark Dec 13, 2017
WilcoFiers added a commit that referenced this issue Dec 15, 2017
…ble name #640 (#642)

* fix(rules/region): Treat <section> as a landmark if it has an accessible name #640

* chore(checks/region): Add clarifying comment
WilcoFiers added a commit that referenced this issue Dec 15, 2017
…ble name #640 (#642)

* fix(rules/region): Treat <section> as a landmark if it has an accessible name #640

* chore(checks/region): Add clarifying comment
@iamrafan
Copy link
Contributor Author

iamrafan commented Mar 7, 2018

thanks @WilcoFiers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants