Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(imports): add doT template engine #1024

Merged
merged 6 commits into from
Jul 31, 2018
Merged

Commits on Jul 30, 2018

  1. feat(imports): add doT template engine

    This patch adds the [`doT`](https://npmjs.org/dot) template engine to `axe.imports`. This is required for a runtime localization (a WIP feature).
    
    A lot of hackery was required to get this working, since `doT` doesn't expose a UMD wrapper that our build system supports. Rather than attempting to get our existing tooling to "unwrap" `doT`'s custom UMD, I've decided to save a lot of time/effort and just wrap it in an IIFE. There are likely 1,000,000s of variations of UMD in the wild and it's unreasonable for us to attempt to support them all. The added IIFE method works in cases where the code functions exactly the same regarless of enviroment (this does not include libraries like Axios). IMHO the only reasonable solution to this problem is to use a proper bundler for building `axe-core`.
    stephenmathieson committed Jul 30, 2018
    Configuration menu
    Copy the full SHA
    bbcf13a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    97acbce View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    27edc00 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e19a494 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2018

  1. Configuration menu
    Copy the full SHA
    ca335f6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    046d270 View commit details
    Browse the repository at this point in the history