fix: better unsupported attribute support for aria-roledescription #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
reviewed
Feb 20, 2019
…d flag from validateAttr
jeeyyy
reviewed
Feb 21, 2019
jeeyyy
previously requested changes
Feb 22, 2019
jeeyyy
previously requested changes
Feb 25, 2019
|
@WilcoFiers |
WilcoFiers
previously requested changes
Feb 26, 2019
lib/checks/aria/unsupportedattr.js
Outdated
| const unsupported = attribute.unsupported; | ||
|
|
||
| if (typeof unsupported === 'boolean' || !unsupported.exceptions) { | ||
| return true; |
There was a problem hiding this comment.
Nitpick, rather than checking if unsupported is falsey on line 8, I think this code would be a little easier to read if you check on line 14 if unsupported is not an object, and on line 14 do return !!unsupported.
lib/checks/aria/unsupportedattr.js
Outdated
| } | ||
|
|
||
| // validate attributes and conditions (if any) from allowedElement to given node | ||
| let out = axe.commons.matches(node, unsupported.exceptions); |
There was a problem hiding this comment.
let out = -> const isException =
WilcoFiers
approved these changes
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand the
unsupportedproperty of an attribute by allowing certain elements to use the attribute.Closes: #1216
Reviewer checks
Required fields, to be filled out by PR reviewer(s)