Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frame-title): return incomplete for presentational iframe with empty title #3594

Merged
merged 10 commits into from
Sep 5, 2022
Merged

fix(frame-title): return incomplete for presentational iframe with empty title #3594

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
affae2d
fix(frame-title): account for presentational role conflict
straker Aug 10, 2022
faf7143
remove frame
straker Aug 10, 2022
1b70c46
fix virtual rule
straker Aug 10, 2022
b7be6af
Update test/integration/rules/frame-title/frame-title.html
straker Aug 16, 2022
5430d95
report for iframe and title
straker Aug 26, 2022
1d98282
finalize
straker Aug 29, 2022
56193ad
Merge branch 'develop' into frame-presentational
straker Aug 29, 2022
0c7adf8
enable act rule
straker Aug 29, 2022
37e92f4
test
straker Aug 29, 2022
3a34d9d
test
straker Aug 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/commons/dom/is-natively-focusable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ function isNativelyFocusable(el) {
case 'select':
case 'summary':
case 'button':
case 'iframe':
straker marked this conversation as resolved.
Show resolved Hide resolved
return true;
case 'details':
return !querySelectorAll(vNode, 'summary').length;
Expand Down
Loading