-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aria-required-children): fail for children which are not listed as required #3597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straker
changed the title
fix(aria-required-children): fail for child elements which are not listed as required
fix(aria-required-children): fail for children which are not listed as required
Aug 10, 2022
WilcoFiers
previously requested changes
Aug 12, 2022
test/integration/rules/aria-required-children/aria-required-children.html
Show resolved
Hide resolved
test/integration/rules/aria-required-children/aria-required-children.html
Show resolved
Hide resolved
straker
commented
Aug 12, 2022
WilcoFiers
previously approved these changes
Aug 16, 2022
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
WilcoFiers
approved these changes
Aug 18, 2022
straker
changed the title
fix(aria-required-children): fail for children which are not listed as required
feat(aria-required-children): fail for children which are not listed as required
Aug 18, 2022
This was referenced Jan 3, 2023
Thank you, Adam. Thank you, |
This was referenced May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue: #3468 and #3462