Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(table-duplicate-name): use virtual node #3604

Merged
merged 9 commits into from
Aug 18, 2022

Conversation

dbowling
Copy link
Contributor

  • use virtual node

references: #3473

@dbowling dbowling marked this pull request as ready for review August 15, 2022 02:04
@dbowling dbowling requested a review from a team as a code owner August 15, 2022 02:04
lib/checks/tables/same-caption-summary-evaluate.js Outdated Show resolved Hide resolved
lib/checks/tables/same-caption-summary-evaluate.js Outdated Show resolved Hide resolved
lib/checks/tables/same-caption-summary-evaluate.js Outdated Show resolved Hide resolved
lib/checks/tables/same-caption-summary-evaluate.js Outdated Show resolved Hide resolved
@dbowling dbowling requested a review from WilcoFiers August 16, 2022 20:57
@dbowling dbowling dismissed WilcoFiers’s stale review August 16, 2022 21:06

all changes were made

lib/checks/tables/same-caption-summary-evaluate.js Outdated Show resolved Hide resolved
lib/checks/tables/same-caption-summary.json Outdated Show resolved Hide resolved
@dbowling dbowling requested a review from WilcoFiers August 17, 2022 15:54
@dbowling dbowling dismissed WilcoFiers’s stale review August 17, 2022 17:28

Changes made and re-requested review

@dbowling dbowling merged commit 4e57881 into develop Aug 18, 2022
@dbowling dbowling deleted the 3473-table-duplicate-name branch August 18, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants