Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(target-size): show closest offset in message #4151

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

WilcoFiers
Copy link
Contributor

Fixes a typo in the remediation message. I checked the localisations, none of them have the {$ instead of ${ problem, although we do need the translators to fix the bracket issue I think. Hoping @ma10 can pick that up for Japanese.

Closes: #4148, closes #4149

@WilcoFiers WilcoFiers requested a review from a team as a code owner September 7, 2023 10:33
@ma10
Copy link
Contributor

ma10 commented Sep 8, 2023

Hoping @ma10 can pick that up for Japanese.

Yes, I will prepare a pull request and send it once this one gets finalized and merged.

BTW, while it's quite easy to notice newly added messages, catching updates to existing messages is not so. I hope we can come up with some mechanism to make it easy to track the translation status, or maybe it's just that I'm not aware of some common techniques for this kind of tasks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

target-size rule contains typos
3 participants