-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shadow DOM docs #471
Merged
Merged
Shadow DOM docs #471
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
36a0551
docs(API): change mentions of a11yCheck to axe.run
7331bb0
docs: add Shadow DOM documentation
7d859dc
docs: add Shadow DOM documentation
9f8ab45
docs: try to fix virtual dom table of contents
38c0c50
docs(API.md): fix tabs in table of contents
2014d57
chore: rename file as accessible-text-virtual
dd12381
feat: add missing accessibleTextVirtual method
278a6c6
docs: remove axe._tree, make copy adjustments
e05d0a7
docs: remove axe._tree from TOC
f1c7eb2
docs: add shadowID info to developer guide
fca4cc3
docs: document testUtils and a few commons
5a4fec4
docs: add line about ShadowDOM to contributing
d44ee3b
docs: move Shadow APIs to "core API" section
324ecdd
docs: fix API TOC
adcd227
docs: move core/test APIs to developer guide
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A caller should always call this with the shadowID
undefined
as this parameter is intended only to be used by the recursive callsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not quite following. Can't we set it as
undefined
if it doesn't get passed in? This may also be moot if we drop documentation of this function.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nbd - I was just suggesting adding a note to say that it is not intended to be directly used by an external caller