Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aria): adding support for aria-expanded in menuitem #521

Merged
merged 1 commit into from
Sep 15, 2017
Merged

fix(aria): adding support for aria-expanded in menuitem #521

merged 1 commit into from
Sep 15, 2017

Conversation

devaradhanm
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Sep 13, 2017

CLA assistant check
All committers have signed the CLA.

@marcysutton
Copy link
Contributor

Thanks for this PR! I'm including the discussion that occurred outside of Github for additional context:

Looks like it is coming in the ARIA 1.2 spec: w3c/aria#454

"Given there is consensus this should be changed in the spec for ARIA 1.2 and that it is already implemented in browsers on all major platforms, per discussion in last week's APG meeting, we plan to leave it in the APG examples with an appropriate note that will link here."

@marcysutton marcysutton merged commit b4c42fe into dequelabs:develop-2x Sep 15, 2017
@senorfrench61
Copy link

Hi, I see menuitem is supported now. How about menu? I am setting aria-expanded to true and false on a link that has aria-popup="true" in order to view submenu items but to also see 'expanded' and 'collapsed'. It works fine in IE and FF, but not my Chrome Version 78.0.3904.97 (Official Build) (64-bit).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants