fix view sorting being reset #2736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
rm-hull
added a commit
to rm-hull/k9s
that referenced
this pull request
Aug 12, 2024
* 'master' of github.com:derailed/k9s: (169 commits) fix: align build image Go version with go.mod (derailed#2812) Bump github.com/docker/docker (derailed#2816) Bump golangci/golangci-lint-action from 6.0.1 to 6.1.0 (derailed#2813) Add comment about Escape keybinding (derailed#2817) proper handle OwnerReference for manually created job (derailed#2772) [derailed#2773] fix freebsd build failure (derailed#2775) install copyright file into correct location (derailed#2780) fix status for completed pods in workload view (derailed#2729) update deps [Maint] Bump grype rev K9s/release v0.32.5 (derailed#2740) --- (derailed#2707) fix view sorting being reset (derailed#2736) use policy/v1 instead of policy/v1beta1 (derailed#2732) Bump alpine from 3.19.1 to 3.20.0 (derailed#2721) fix: jump to namespaceless owner reference (derailed#2718) feat: Add plugins for argo-rollouts (derailed#2711) Bump golangci/golangci-lint-action from 5.1.0 to 6.0.1 (derailed#2702) allow jumping to the owner of the resource (derailed#2700) fix: job color based on failures (derailed#2686) (derailed#2698) ...
thorbenbelow
pushed a commit
to thorbenbelow/k9s
that referenced
this pull request
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR fixes #2734.
When the
Initmethod in theview.Tableobject is executed, theapp.RefreshCustomViewsmethod is called to reload the custom view, which triggers theViewSettingsChangedevent, ultimately causes theui.Tableobject to reset the sorting of the user settings.