feat(meta): add lightning address as metadata #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Official spec here: BitcoinAndLightningLayerSpecs/rfc#1 |
bumi
reviewed
Feb 18, 2022
| <!-- Lightning Address for Alby's Value4Value extensions --> | ||
| {% capture shortName %}{{ page.redirect_from | replace: '/', '' }}{% endcapture %} | ||
| {% capture lightningAddress %}{% if shortName %}{{ shortName }}{% else %}{{ 's@ts.dergigi.com' }}{% endif %}{% endcapture %} | ||
| <meta name="lightning" content="lnurlp:{{ lightningAddress }}"/> |
There was a problem hiding this comment.
I wanted to send some sats and test it, but it seems your lightningAddress is empty here. jfyi. :)
There was a problem hiding this comment.
ich habe keine Ahnung von liquid templates, aber muss das sowas sein?
{% capture lightningAddress %}{% if shortName != '' %}{{ shortName | append: "@ts.dergigi.com" }}{% else %}{{ 's@ts.dergigi.com' }}{% endif %}{% endcapture %}
also wenn der shortName nicht ein empty string ist (der shortName wird auf '' gesetzt und ist deshalb bisher truthy) dann soll die addresse {shortName}@ts.dergigi.com sein, ansonsten s@ts.dergigi.com
There was a problem hiding this comment.
vielleicht auch:
{% capture lightningAddress %}{% if shortName == blank %}{{ 's@ts.dergigi.com' }}{% else %}{{ shortName | append: "@ts.dergigi.com" }}{% endif %}{% endcapture %}
There was a problem hiding this comment.
Thank you! Should be fixed with #288 - might take a minute or two until it is live. Tested it on local, and it truly should be fixed now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Alby's value4value extension: https://getalby.com/value4value