Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: imports in test #249

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Chore: imports in test #249

merged 2 commits into from
Jun 13, 2023

Conversation

LondonCalamari
Copy link
Contributor

Summary

Describe the changes made in your pull request here.

Details

Any implementation detail worth pointing out, if any.

Todo

Breakdown the progress of the PR for everyone to see what else you intend to include in this PR.

(Examples:)

  • Draft implementation for function
  • Unit tests for function
  • Gas optimization for function

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Add natspec for all functions / parameters
  • Ran forge snapshot
  • Ran forge fmt
  • Ran forge test
  • Triage Slither issues, and post uncertain ones in the PR
  • 100% test coverage on code changes

Slither Issues (Optional)

If you're unsure about a new issue reported by Slither, copy them here so others can verify as well.

@LondonCalamari LondonCalamari changed the title Chore: import in test Chore: imports in test Jun 13, 2023
Copy link
Contributor

@antoncoding antoncoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #249 (081a948) into master (57c6117) will not change coverage.
The diff coverage is n/a.

❗ Current head 081a948 differs from pull request most recent head e0488d3. Consider uploading reports for the commit e0488d3 to get more accurate results

@@           Coverage Diff           @@
##           master     #249   +/-   ##
=======================================
  Coverage   97.83%   97.83%           
=======================================
  Files          28       28           
  Lines        1476     1476           
  Branches      264      264           
=======================================
  Hits         1444     1444           
  Misses          2        2           
  Partials       30       30           

@LondonCalamari LondonCalamari merged commit f8c5380 into master Jun 13, 2023
@LondonCalamari LondonCalamari deleted the feat/import branch June 13, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants