refactor(codebase): improve modularity, readability and maintainability #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OOP doesn't seem to be feasible with FiveM's LUA integration. For that matter, I am looking into a C# solution instead. Pushing and releasing with the latest working OOP approach also doesn't feel right, since the entire configuration changes and will change again with a C# solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update aims to elevate the codebase to the next level by adopting OOP style and by following common coding guidelines and good practices.
No features have been added/removed.
This also comes with a downside, the config file structure changes drastically and requires the user to add their configuration all over again.
There is no plan to change the style and design of the config again.