Only take runtime defs as passed to client instantiation functions #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long story short, figuring out which composeDB runtime definitions to use is non-trivial and can't really be done automatically from the lib. The reason for this is that they will change on every deploy, so the ones included will likely not work for someone else if they deploy to their local dev cluster, because the streamID's of the models will have changed.
When there is a public deployment, the lib can default to the corresponding runtime definition. Until then, when instantiating a composeDB client with the codex lib, one will have to pass the runtime definition object.