nodes-media fixes #257
Merged
nodes-media fixes #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m0ar
commented
Mar 25, 2024
Comment on lines
-25
to
+31
| "cors": "^2.8.5", | ||
| "body-parser": "^1.20.2", | ||
| "express": "^4.17.1", | ||
| "express-fileupload": "^1.4.0", | ||
| "imagemagick": "^0.1.3", | ||
| "jsonwebtoken": "^8.5.1", | ||
| "kubo-rpc-client": "^3.0.4", | ||
| "morgan": "^1.10.0", | ||
| "node-latex": "^3.1.0", | ||
| "reflect-metadata": "^0.1.13" | ||
| "reflect-metadata": "^0.1.13", | ||
| "temp": "^0.9.4" |
There was a problem hiding this comment.
Some were unused, some used but not registered as dependencies
m0ar
commented
Mar 25, 2024
| "build": "rimraf dist && tsc", | ||
| "start": "NODE_PATH=./dist node ./dist/index.js", |
There was a problem hiding this comment.
This is unnecessary when the cursed and deprecated baseUrl config is removed, because now you can make sense of the import paths in emitted js files without being clairvoyant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some errors related to some deps upgraded to ESM unveiled some non-standard tsconfig options which emitted code not compatible with newer versions of node. This should fix all the low hanging "typechecks but fails in runtime" 🌴
Not entirely sure how to test this properly locally, but it builds and runs both locally and in docker 🤞