Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add traceIds to logs and also fix ipfs image imports #362

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

hubsmoke
Copy link
Member

Description of the Problem / Feature

  • when logging to betterstack we have no ability to tell which log items were related or which user triggered them

secondarily: when developing locally certain images were expected to be on IPFS public resolver, but when deving locally we use a private IPFS node which has no access

Explanation of the solution

  • add traceId to all requests
  • make any other log lines read from AsyncLocalStorage to also include traceId
  • log the userId if logged in
  • send X-Desci-Trace-Id in response for debugging failed requests in the wild

secondarily: - add import-ipfs-content.sh script to fix broken images when local dev

Instructions on making this work

no action required

@hubsmoke hubsmoke merged commit 9812963 into develop Jun 12, 2024
1 check passed
@m0ar m0ar deleted the fix-logging-and-imgs branch June 18, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant