Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix token ownership checks on upgrade, et. al. #590

Merged
merged 13 commits into from
Oct 23, 2024
Merged

Fix token ownership checks on upgrade, et. al. #590

merged 13 commits into from
Oct 23, 2024

Conversation

m0ar
Copy link
Contributor

@m0ar m0ar commented Oct 22, 2024 •
edited
Loading

Description of the Problem / Feature

  • check token/stream owner consensus before doing backfill in nodes-lib
  • check token/stream owner consensus before upgrading legacy dPID to alias in desci-server
  • add script for manually issuing dpid upgrades (history healing)
  • unbreak nodes-lib test suite
    • disable draft document cache
  • move publish successful interactionLog to after all tasks (remove false positives)
  • add publish failed interactionLog in main catch (actually save failures)
  • fix some import cycles (mostly related to wonky imports for process hook handlers in redisClient.ts)
  • fix fatal error handling
    • stop accepting new requests
    • actually crash on uncaught exceptions
    • actually perform cleanup

@m0ar m0ar added bug Something isn't working enhancement New feature or request labels Oct 22, 2024
@m0ar m0ar self-assigned this Oct 22, 2024
m0ar
m0ar commented Oct 23, 2024
View reviewed changes
desci-server/src/controllers/nodes/draftCreate.ts
Comment on lines -149 to +150
await setToCache(`node-draft-${node.uuid}`, { document, documentId }, 60);
// ! disabling, as it breaks programmatic interaction from nodes-lib, where stale results break interactivity
// await setToCache(`node-draft-${ensureUuidEndsWithDot(node.uuid)}`, { document, documentId }, 60);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heads up @shadrach-tayo 🙏

@m0ar m0ar merged commit 706443b into develop Oct 23, 2024
1 check passed
@m0ar m0ar deleted the m0ar/fix-stream-checks branch October 23, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@m0ar m0ar

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@m0ar