fixes

descope · Sep 29, 2024 · 2846114 · 2846114
1 parent 0741e62
commit 2846114
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 22 deletions.
diff --git a/packages/sdks/nextjs-sdk/examples/app-router/app/my-applications-portal/page.tsx b/packages/sdks/nextjs-sdk/examples/app-router/app/my-applications-portal/page.tsx
@@ -12,12 +12,9 @@ export default () => (
 			justifyContent: 'center'
 		}}
 	>
-		<h1>User Profile</h1>
+		<h1>Applications Portal</h1>
 		<ApplicationsPortal
 			widgetId="applications-portal-widget"
-			onLogout={() => {
-				window.location.href = '/login';
-			}}
 		/>
 	</div>
 );
diff --git a/packages/sdks/react-sdk/src/components/ApplicationsPortal.tsx b/packages/sdks/react-sdk/src/components/ApplicationsPortal.tsx
@@ -50,15 +50,6 @@ const ApplicationsPortal = React.forwardRef<
       innerRef.logger = logger;
     }
   }, [innerRef, logger]);
-
-  useEffect(() => {
-    if (innerRef && onLogout) {
-      innerRef.addEventListener('logout', onLogout);
-      return () => innerRef.removeEventListener('logout', onLogout);
-    }
-    return undefined;
-  }, [innerRef, onLogout]);
-
   return (
 	<Suspense fallback={null}>
 		<ApplicationsPortalWC

diff --git a/packages/sdks/vue-sdk/example/components/MyApplicationsPortal.vue b/packages/sdks/vue-sdk/example/components/MyApplicationsPortal.vue
@@ -1,7 +1,7 @@
 <!-- eslint-disable vue/multi-word-component-names -->
 <template>
   <div class="applications-portal-wrapper">
-    <h1>Applications Portal!!</h1>
+    <h1>Applications Portal</h1>
     <ApplicationsPortal widget-id="applications-portal-widget" />
   </div>
 </template>

diff --git a/packages/sdks/web-component/src/lib/descope-wc/index.ts b/packages/sdks/web-component/src/lib/descope-wc/index.ts
@@ -8,4 +8,6 @@ if (!customElements.get('descope-wc')) {
 }
 export default DescopeWc;
 
-export type { AutoFocusOptions, ThemeOptions, ILogger } from '../types';
+export type ILogger = Partial<DescopeWc['logger']>
+
+export type { AutoFocusOptions, ThemeOptions } from '../types';
diff --git a/packages/sdks/web-component/src/lib/types.ts b/packages/sdks/web-component/src/lib/types.ts
@@ -157,13 +157,6 @@ export interface Context {
   abTestingKey?: number;
 }
 
-export interface ILogger {
-  info(title: string, description: string, state: any): void;
-  warn(title: string, description?: string): void;
-  debug(title: string, description?: string): void;
-  error(title: string, description?: string, ...optionalParams: any[]): void;
-}
-
 export type DescopeUI = Record<string, () => Promise<void>> & {
   componentsThemeManager: Record<string, any>;
 };