Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue SDK: usage example mistakes: 'isSessionLoading' 'isUserLoading' utilities #811

Closed
camslice opened this issue Sep 29, 2024 · 1 comment · Fixed by #813
Closed

Vue SDK: usage example mistakes: 'isSessionLoading' 'isUserLoading' utilities #811

camslice opened this issue Sep 29, 2024 · 1 comment · Fixed by #813
Assignees

Comments

@camslice
Copy link

Usage example:

const { isSessionLoading } = useSession();
const { isUserLoading } = useUser();

Both isSessionLoading and isUserLoading are undefined. Usage example should be updated to:

const { isLoading: isSessionLoading } = useSession();
const { isLoading: isUserLoading } = useUser();
@camslice camslice changed the title Descope Vue SDK: usage example mistakes 'isSessionLoading' 'isUserLoading' Vue SDK: usage example mistakes: 'isSessionLoading' 'isUserLoading' utilities Sep 29, 2024
asafshen added a commit that referenced this issue Sep 29, 2024
## Related Issues
related to descope/etc#7827
fixes #811
fixes #810
fixes #812

## Description
- change logger interface to be more loose ➰ 
- fix vue sdk readme based on a feedback 👍 
 - add style id to vue sdk
 

![image](https://github.com/user-attachments/assets/78165245-8be4-4117-8a07-b4b3ce7f1220)

![image](https://github.com/user-attachments/assets/58ab1026-6795-4e80-8682-ae3e59348832)
@camslice
Copy link
Author

camslice commented Oct 1, 2024

@asafshen looks good 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants