Feature: add custom date format #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krassowski
requested changes
Sep 6, 2023
There was a problem hiding this comment.
Thank you for this PR, I tested it locally and it works well.
The format string configuration may be cumbersome and error-prone without a reference and input validation handling. I made two suggestions inline, let me know what you think or have any questions.
There are also some typos in the settings, and I would suggest reverting the yarn.lock changes.
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
krassowski
reviewed
Sep 8, 2023
krassowski
reviewed
Sep 8, 2023
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
|
Needs actually importing |
|
I have imported the I also include where the error is from in the title of the dialog box. This will help the user identify where the error is from when they refresh the browser. |
krassowski
approved these changes
Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature enable a user to add a custom date format.
i.e
yyy-MM-dd HH:mm:ssresult to2023-02-28 14:25:57.dd/MM/YYY HH:mm:ss (O)results to28/02/2023 14:25:57 (GMT +3),This is based on the date-fns format