-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update quickgen and quickbrick to new specsim API #86
Conversation
I was surprised by this snippet:
It seems that wavemin/wavemax from desimodel should be part of the default desi config. I haven't looked under the hood for how or where specsim is getting that desi config, however. Should that config be encoded as a file in desimodel itself? Perhaps desimodel should have a load_specsim_config() function that returns a properly configured specsim Configuration object for the parameters in that version of desimodel? i.e. can we find a way to load a fully correct desi configuration directly, without having to load it and then modify it to get it into the actually correct state to use? |
In this PR, I am aiming for the minimal changes required by the new specsim API, while preserving identical output results. In that spirit, I did not change how quickbrick sets its limits (which are different from those used by quickgen) even though it doesn't make any practical difference as long as the simulation limits include the throughput limits. However, it does make a tiny numerical difference since changing the grid min adds a sub-pixel offset to the grid, so I wanted to avoid that complication for my testing. Looking ahead, it would be good to pick a canonical simulation range used by both quickgen and quickbrick, and update the specsim desi.yaml if necessary. Currently, it contains:
While the throughput limits (which specsim also knows about from the throughput files) are:
Note that
but I eliminated the +/-1 padding in this PR since it makes no difference to the results. |
I just tagged and released specsim v0.3 so this PR is ready to merge as far as I am concerned. |
Looks fine to me. Refactoring the wavelength grid provenance can be a future PR. Merge away! |
desihub/desimodel#7 is relevant to the question of what the canonical grid should actually be. |
Update quickgen and quickbrick to new specsim API
This is not ready to merge until I tag and release specsim v0.3, but now passes my tests on #80 using desihub/specsim#29. Please review if you are interested. I am finding identical results after the updates, but your mileage may vary.
Note that there are some trivial diffs in this PR where my editor (atom) automatically removed the invisible white space from the end of lines. Sorry about that. Could we standardize our whitespace conventions using editorconfig? For example, the conventions I use in specsim are specified here.