-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct output resolution matrix #132
Conversation
@julienguy, could you please review this? it is possible this fixes #137. |
f6550b8
to
f6a457c
Compare
I have rebased this branch on main so that test will now run automatically. |
@p-slash, apparently we decided to work on this at the exact same time. Please let me know what your next steps are. |
Thanks @weaverba137 . This fix was needed after PR #128 where I changed how the input resolution matrix was downsampled to DESI resolution. It compares the downsampled resolution matrix to theoretical expectations, though a relative tolerance of 0.1% is needed to pass this test. As far as I know, these two PRs affect only Lya forest P1D, and we have been happy about it. |
@p-slash, OK, if you have no objections, I'll clean up and merge this PR. |
I'm also adding a quick fix for #133. |
No objections. Thanks |
This PR redesigns the test for the new resolution matrix output by comparing each row to theoretically expected values.