Simulation realism: part 1 #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fig constant in um/arcsec
…l focal plane (x,y)
|
@sbailey @moustakas I am planning to merge this tomorrow so I can start work on part 2, but let me know if I should hold off to allow time for review. Integration with desisim will not start until the dust settles on part 2. |
|
I'm not set up right now to test the code, but I did read through all the proposed changes. Everything looks good as far as I can tell. I wonder whether users will get tripped-up by having to specify the units with the exposure time (lines 30-31 of |
|
I actually made the same mistake ('m' vs 'min') when I was testing, so I just improved the error handling: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first major piece of adding simulation realism. The simulation now knows about the plate scale variation across the focal plane and can locate simulated sources on the focal plane, resulting in the correct variation of on-sky fiber area and shape.
The next step is to upgrade the fiber acceptance fraction calculations #5 so that the source throughput reflects focal plane position (currently only the sky background level reflects the on-sky fiber area).
Fixes #24.