Use banner to announce line endings change warning in diffs #18084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tidy-dev
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref. https://github.com/github/accessibility-audits/issues/7012
Description
After the work from #18069 , @tidy-dev pointed out that even with that change the icon would still not be fully accessible, so she suggested to use the warning banner we have for Unicode bidi characters (included in #13343).
This PR does exactly that. However, when both warnings (Unicode bidi characters and line endings change) are present, we have considered two: warnings stacked with no separator or with separator. In the end we decided to go with separator, but we're open to hear other ideas.
Screenshots
Release notes
Notes: [Fixed] Promote line endings change warning from icon to a banner, improving its accessibility