Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the enum and regex for when a branch rename command fails #172

Merged
merged 4 commits into from
Mar 24, 2018
Merged

Added the enum and regex for when a branch rename command fails #172

merged 4 commits into from
Mar 24, 2018

Conversation

ysabri
Copy link
Contributor

@ysabri ysabri commented Mar 22, 2018

So I noticed that the rename branch error is not included and added it.

I can submit more if I find any, unless that is something the project is not looking for?

@shiftkey
Copy link
Member

@ysabri that CI error is unrelated to your changes, but would you be able to add a test to git-process-test.ts that includes the whole Git output from this error, to confirm the regex is being captured correctly?

@ysabri
Copy link
Contributor Author

ysabri commented Mar 23, 2018

I just added the test, let me know if there is anything else I need to do.

Copy link
Member

@shiftkey shiftkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @ysabri!

@shiftkey shiftkey merged commit fbd24b5 into desktop:master Mar 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants