Make sure we are copying the path variable #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tidy-dev
force-pushed
the
fix-buiding-env-path
branch
from
53d5f10 to
c974bb1
Compare
…nemies Path environment variable tweaks
niik
approved these changes
Jun 5, 2024
tidy-dev
added a commit
that referenced
this pull request
Jun 5, 2024
Make sure we are copying the path variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per some hook failures investigation, we determined that the changes in #563 were causing the
PATHenvironment variable to be replaced on Windows. This was causing issues with local hooks, as they rely on thePATHenvironment variable to be set correctly.This PR ensures that the
PATHenvironment variable is always set when building our env object.