build(deps): bump cosmos-sdk from 0.47.4 to 0.47.5 #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dadamu
commented
Sep 22, 2023
Comment on lines
+282
to
+288
| storeKeys := sdk.NewKVStoreKeys( | ||
| ibcexported.StoreKey, ibctransfertypes.StoreKey, ibcfeetypes.StoreKey, | ||
| icahosttypes.StoreKey, icacontrollertypes.StoreKey, wasmtypes.StoreKey, | ||
| ) | ||
| app.MountKVStores(app.keys) | ||
| for _, key := range storeKeys { | ||
| app.RegisterStores(key) | ||
| } |
There was a problem hiding this comment.
In the new version, stores can be set by new function RegisterStores inside BaseApp, so we don't need to handle store keys inside DesmosApp.
See:
cosmos/cosmos-sdk#17284
dadamu
commented
Sep 22, 2023
| s.RegisterServices(cfg) | ||
| } | ||
| if err := app.RegisterModules(legacyModules...); err != nil { | ||
| panic(err) | ||
| } |
There was a problem hiding this comment.
RegisterServices now is covered inside RegisterModules, the manually services setting can be removed safely, or it would panic since the double setting.
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
dadamu
force-pushed
the
paul/bump-cosmos-sdk-to-0.47.5
branch
from
63e1ff0
to
a5d609e
Compare
RiccardoM
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
This PR bumps cosmos-sdk to 0.47.5 from 0.47.4.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change