Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed dTag CLI command #282

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Fixed dTag CLI command #282

merged 1 commit into from
Oct 6, 2020

Conversation

leobragaz
Copy link
Contributor

Description

This PR fixes the problem raised inside issue 281.
Closes #281 .

Checklist

  • Targeted PR against correct branch.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit tests.
  • Wrote integration tests (simulation & CLI).
  • Updated the documentation.
  • Added an entry to the CHANGELOG.md file.
  • Re-reviewed Files changed in the Github PR explorer.

@leobragaz leobragaz requested a review from RiccardoM October 6, 2020 10:04
@leobragaz leobragaz self-assigned this Oct 6, 2020
RiccardoM
RiccardoM approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@RiccardoM RiccardoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast and furious! 🚀

@RiccardoM RiccardoM merged commit 90d3089 into master Oct 6, 2020
@RiccardoM RiccardoM deleted the leonardo/dtag-cmd-fix branch October 6, 2020 10:17
@kwunyeung kwunyeung mentioned this pull request Oct 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RiccardoM RiccardoM RiccardoM approved these changes

Assignees

@leobragaz leobragaz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong CLI command name to accept dTag
2 participants
@leobragaz @RiccardoM