-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Case insensitive chain name #533
Conversation
Codecov Report
@@ Coverage Diff @@
## master #533 +/- ##
=======================================
Coverage 81.81% 81.82%
=======================================
Files 91 91
Lines 4734 4736 +2
=======================================
+ Hits 3873 3875 +2
Misses 667 667
Partials 194 194
Continue to review full report at Codecov.
|
2a58b51
to
04f72b6
Compare
…n-name-case-insensitive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation looks good, but I'm having a hard time deciding whether this is worth or it might have some backslash in the future
@@ -22,7 +22,7 @@ import ( | |||
// NewChainConfig allows to build a new ChainConfig instance | |||
func NewChainConfig(name string) ChainConfig { | |||
return ChainConfig{ | |||
Name: name, | |||
Name: strings.ToLower(name), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be removed if we want the Validate
method to fail
@RiccardoM why backslash? I don't think we will see chains where name differs only for some case letter. |
Description
This PR makes the name of
ChainConfig
case insensitive.Closes #526
Checklist
CHANGELOG.md
file.Files changed
in the Github PR explorer.