Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepare v3.0.0 #769

Merged
merged 29 commits into from
Mar 15, 2022
Merged

chore: prepare v3.0.0 #769

merged 29 commits into from
Mar 15, 2022

Conversation

RiccardoM
Copy link
Contributor

@RiccardoM RiccardoM commented Mar 8, 2022

Description

Prepares the new v3.0.0 version of Desmos. Changes included are:

  • updated the .changeset/config.yaml to better generate the changelog
  • updated Cosmos Proto definitions references to v0.45.1
  • changed the keys used to store x/profiles data to take up less space
  • fixed the wrong type for MsgDeleteSubspace
  • fixed the on-chain upgrade workflow
  • fixed any bug about the migration

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

RiccardoM added 19 commits March 8, 2022 14:51
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
…mmand

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
@github-actions github-actions bot added kind/build Related to the build of the project kind/ci Improve the CI/CD x/profiles Module that allows to create and manage decentralized social profiles x/subspaces Issue on the x/subspaces module labels Mar 8, 2022
@RiccardoM RiccardoM requested review from dadamu and leobragaz March 8, 2022 13:56
@RiccardoM RiccardoM added the requires-upgrade Test the on-chain upgrade for this PR label Mar 8, 2022
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #769 (46c9585) into master (ce83cc5) will decrease coverage by 0.01%.
The diff coverage is 81.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #769      +/-   ##
==========================================
- Coverage   81.32%   81.30%   -0.02%     
==========================================
  Files          77       76       -1     
  Lines        6239     6495     +256     
==========================================
+ Hits         5074     5281     +207     
- Misses        934      970      +36     
- Partials      231      244      +13     
Impacted Files Coverage Δ
app/app.go 82.20% <16.66%> (-0.99%) ⬇️
x/profiles/client/cli/cli_app_links.go 33.59% <53.84%> (-0.58%) ⬇️
x/profiles/client/cli/cli_chain_links.go 81.57% <53.84%> (-4.28%) ⬇️
x/profiles/legacy/v1beta1/keeper.go 83.44% <83.44%> (ø)
x/profiles/legacy/v1beta1/store.go 84.91% <84.91%> (ø)
x/profiles/client/cli/cli_dtag_requests.go 82.20% <100.00%> (ø)
x/profiles/keeper/alias_functions.go 92.85% <100.00%> (ø)
x/profiles/keeper/grpc_query.go 74.57% <100.00%> (+0.97%) ⬆️
x/profiles/simulation/decoder.go 100.00% <100.00%> (ø)
x/profiles/types/codec.go 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e45e5a...46c9585. Read the comment docs.

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Copy link
Contributor

@leobragaz leobragaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any comments about the coverage drop? Is that due to the added legacy files?

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
@github-actions github-actions bot added the x/CLI label Mar 11, 2022
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
@dadamu
Copy link
Contributor

dadamu commented Mar 14, 2022

test failed since the version of the profile codec should be v2 instead of v3 now.

@RiccardoM
Copy link
Contributor Author

@dadamu Can you help me fix it please? I've changed it to be v2 since this will be the second version of the profiles module actually (as the first one was the v1beta1 version)

@dadamu
Copy link
Contributor

dadamu commented Mar 14, 2022

@RiccardoM Fixed

@dadamu
Copy link
Contributor

dadamu commented Mar 15, 2022

@RiccardoM Fixed the x/profiles version issue as well.

@dadamu dadamu requested a review from leobragaz March 15, 2022 07:47
Copy link
Contributor

@leobragaz leobragaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks ready now

@RiccardoM RiccardoM added the automerge Automatically merge PR once all prerequisites pass label Mar 15, 2022
@RiccardoM RiccardoM requested a review from dadamu March 15, 2022 10:46
@RiccardoM
Copy link
Contributor Author

As soon as @dadamu accepts this it will get merged then 💯

Copy link
Contributor

@dadamu dadamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to ship

@mergify mergify bot merged commit ced44fe into master Mar 15, 2022
@mergify mergify bot deleted the riccardo/prepare-v3.0.0 branch March 15, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once all prerequisites pass kind/build Related to the build of the project kind/ci Improve the CI/CD requires-upgrade Test the on-chain upgrade for this PR x/CLI x/profiles Module that allows to create and manage decentralized social profiles x/subspaces Issue on the x/subspaces module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants