Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: subspaces CLI commands and Proto files wrong notations #815

Merged
merged 10 commits into from
Apr 12, 2022

Conversation

leobragaz
Copy link
Contributor

@leobragaz leobragaz commented Apr 11, 2022

This PR aim to solve some minor issues that I've found inside the x/subspaces module.

  1. Updates the groups CLI commands examples
  2. Fixes wrong notations in subspaces models proto file
  3. Add missing GetCmdDeleteSubspace to the TxCmd
  4. Add missing GetCmdQueryUserGroup to the QueryCmd

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

- updated groups cli commands examples
- fixed wrong notation in proto files
- updated proto generated files
@github-actions github-actions bot added x/CLI x/profiles Module that allows to create and manage decentralized social profiles x/subspaces Issue on the x/subspaces module labels Apr 11, 2022
@RiccardoM RiccardoM changed the title fix: Subspaces cli commands and proto files wrong notations fix: subspaces CLI commands and Proto files wrong notations Apr 11, 2022
@RiccardoM RiccardoM added the automerge Automatically merge PR once all prerequisites pass label Apr 11, 2022
Copy link
Contributor

@RiccardoM RiccardoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a changeset entry here

@leobragaz leobragaz requested review from RiccardoM and dadamu April 11, 2022 10:16
go.mod Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #815 (164f6c8) into master (5475bfe) will not change coverage.
The diff coverage is n/a.

❗ Current head 164f6c8 differs from pull request most recent head 8732802. Consider uploading reports for the commit 8732802 to get more accurate results

@@           Coverage Diff           @@
##           master     #815   +/-   ##
=======================================
  Coverage   81.33%   81.33%           
=======================================
  Files          81       81           
  Lines        6843     6843           
=======================================
  Hits         5566     5566           
  Misses       1017     1017           
  Partials      260      260           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f4f7c6...8732802. Read the comment docs.

updated query commands examples
updated changeset
updated cli command test description
@leobragaz leobragaz requested a review from RiccardoM April 11, 2022 11:10
@leobragaz
Copy link
Contributor Author

I found that GetCmdQueryUserGroup() was missing and added it

@leobragaz leobragaz requested a review from dadamu April 11, 2022 13:35
@mergify mergify bot merged commit 196eb01 into master Apr 12, 2022
@mergify mergify bot deleted the leonardo/subspaces-fixes branch April 12, 2022 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once all prerequisites pass x/CLI x/profiles Module that allows to create and manage decentralized social profiles x/subspaces Issue on the x/subspaces module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants