Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix CLI commands args number #832

Merged
merged 2 commits into from
Apr 26, 2022
Merged

Conversation

RiccardoM
Copy link
Contributor

@RiccardoM RiccardoM commented Apr 22, 2022

Description

This PR fixes some CLI commands args number to properly match the expected ones.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
@RiccardoM RiccardoM requested review from dadamu and leobragaz April 22, 2022 05:52
@github-actions github-actions bot added x/CLI x/profiles Module that allows to create and manage decentralized social profiles labels Apr 22, 2022
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
@RiccardoM RiccardoM added the automerge Automatically merge PR once all prerequisites pass label Apr 22, 2022
@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #832 (7b8e707) into master (c684768) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #832   +/-   ##
=======================================
  Coverage   81.53%   81.53%           
=======================================
  Files          89       89           
  Lines        7018     7020    +2     
=======================================
+ Hits         5722     5724    +2     
  Misses       1035     1035           
  Partials      261      261           
Impacted Files Coverage Δ
x/profiles/client/cli/cli_chain_links.go 82.64% <100.00%> (ø)
x/profiles/client/cli/cli_dtag_requests.go 83.59% <100.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ef1a5b...7b8e707. Read the comment docs.

@RiccardoM RiccardoM mentioned this pull request Apr 22, 2022
19 tasks
@RiccardoM RiccardoM merged commit 9780f34 into master Apr 26, 2022
@RiccardoM RiccardoM deleted the riccardo/fix-cli-commands branch April 26, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once all prerequisites pass x/CLI x/profiles Module that allows to create and manage decentralized social profiles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants