feat: ADR-010: Posts module #847

RiccardoM · 2022-04-27T12:22:34Z

Description

This PR implements the x/posts module as per ADR-010.

Implementation checklist

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

codecov · 2022-04-27T12:27:25Z

Codecov Report

Merging #847 (7a54d90) into master (d27785d) will increase coverage by 0.11%.
The diff coverage is 82.58%.

@@            Coverage Diff             @@
##           master     #847      +/-   ##
==========================================
+ Coverage   81.64%   81.76%   +0.11%     
==========================================
  Files          91      110      +19     
  Lines        7224     9240    +2016     
==========================================
+ Hits         5898     7555    +1657     
- Misses       1052     1363     +311     
- Partials      274      322      +48

Impacted Files	Coverage Δ
x/posts/types/params.go	`56.52% <ø> (ø)`
x/subspaces/types/permissions.go	`73.52% <ø> (ø)`
x/posts/module.go	`8.33% <8.33%> (ø)`
x/posts/keeper/alias_functions.go	`66.00% <66.00%> (ø)`
x/posts/types/models.go	`71.39% <71.39%> (ø)`
x/posts/keeper/keeper.go	`73.68% <73.68%> (ø)`
x/posts/keeper/subspaces_hooks.go	`73.68% <73.68%> (ø)`
x/posts/keeper/grpc_query.go	`82.85% <82.85%> (ø)`
x/posts/keeper/msg_server.go	`85.83% <85.83%> (ø)`
x/posts/keeper/posts.go	`90.35% <90.35%> (ø)`
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d28eca1...7a54d90. Read the comment docs.

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

…posts-implementation � Conflicts: � app/app.go

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

dadamu · 2022-05-20T07:37:31Z

proto/desmos/posts/v1/models.proto

+  repeated uint32 answers_indexes = 4;
+
+  // Address of the user answering the poll
+  bytes user = 5 [ (gogoproto.casttype) =


Why is the type of user is AccAddress instead of bech32 prefixed string? Is it to prevent the double vote with the same address via ibc?

Reverted to use a string instead of a bytes representation

x/posts/keeper/subspaces_hooks.go

x/posts/types/models.go

x/posts/types/msgs.go

x/posts/keeper/posts.go

x/posts/keeper/msg_server.go

x/posts/keeper/posts.go

proto/desmos/posts/v1/query.proto

x/posts/keeper/polls.go

dadamu · 2022-05-25T11:06:26Z

x/posts/keeper/msg_server.go

+			sdk.NewAttribute(types.AttributeKeySubspaceID, fmt.Sprintf("%d", msg.SubspaceID)),
+			sdk.NewAttribute(types.AttributeKeyPostID, fmt.Sprintf("%d", post.ID)),
+			sdk.NewAttribute(types.AttributeKeyAuthor, msg.Author),
+			sdk.NewAttribute(types.AttributeKeyCreationTime, post.CreationDate.Format(time.RFC3339)),


I have a dump question, why timestamp should be indexed?

This is done in order to allow clients to get the creation time from the returned events. Since it is based on the block time, and this is not know to the client, the only way we have to return it to clients (so that they can update the post information locally) is though block events that can later be parsed

Co-authored-by: Paul <p22626262@gmail.com>

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Co-authored-by: Paul <p22626262@gmail.com>

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

…nto riccardo/posts-implementation

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

…posts-implementation

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

…nto riccardo/posts-implementation

dadamu

Ready to go

## Description This PR implements the `x/reports` module as detailed inside [ADR-011](https://github.com/desmos-labs/desmos/blob/master/docs/architecture/adr-011-reports-module.md). Depends-On: #847 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/desmos-labs/desmos/blob/master/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [x] followed the guidelines for [building modules](https://docs.cosmos.network/v0.44/building-modules/intro.html) - [x] included the necessary unit and integration [tests](https://github.com/desmos-labs/desmos/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [x] reviewed "Files changed" and left comments if necessary - [x] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)

RiccardoM added 2 commits April 27, 2022 14:21

added x/posts types

6174fbf

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

added missing validations

8f531ea

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

RiccardoM added 2 commits April 27, 2022 15:20

started the work on the posts keeper

1ff827f

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

added the posts keeper

6ad8e9e

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

github-actions bot added the x/profiles Module that allows to create and manage decentralized social profiles label Apr 28, 2022

RiccardoM added 4 commits April 28, 2022 15:13

started reviewing how attachment contents are handled

37e7124

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

reviewed how attachment contents are represented

4565cc1

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

added messages types

2ceec10

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

added msg server implementation

3fddae7

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

github-actions bot added the x/subspaces Issue on the x/subspaces module label Apr 29, 2022

RiccardoM added 12 commits May 2, 2022 12:00

added msg server tests

14e9b45

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

added missing params and hooks tests

c1daac2

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

added genesis types

266340f

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

adding genesis support to keeper

df16f75

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Merge branch 'master' of github.com:desmos-labs/desmos into riccardo/…

5835c0a

…posts-implementation � Conflicts: � app/app.go

added import genesis tests

711d89d

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

added gRPC querier

b369aa5

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

updated how poll tally results are stored

25c5355

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

added end blocker tests

d515485

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

fixed linting

a3984fa

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

added comment

4b92717

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

added the CLI commands

34349b8

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

github-actions bot added the x/CLI label May 4, 2022

RiccardoM added 5 commits May 4, 2022 15:05

added some more models checks

c1d04f9

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

use PermissionWrite instead of PermissionWriteContent

065e449

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

improved the posts keys

2e29105

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

added simulation tests for the posts module

2bf2e7d

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

fixed test

9ff776f

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

github-actions bot added the kind/adr An issue or PR relating to an architectural decision record label May 5, 2022

dadamu reviewed May 20, 2022

View reviewed changes

x/posts/keeper/subspaces_hooks.go Outdated Show resolved Hide resolved

dadamu reviewed May 20, 2022

View reviewed changes

x/posts/keeper/subspaces_hooks.go Outdated Show resolved Hide resolved

dadamu reviewed May 20, 2022

View reviewed changes

x/posts/types/models.go Outdated Show resolved Hide resolved

dadamu reviewed May 24, 2022

View reviewed changes

x/posts/types/models.go Outdated Show resolved Hide resolved

dadamu reviewed May 24, 2022

View reviewed changes

x/posts/types/models.go Outdated Show resolved Hide resolved

dadamu reviewed May 24, 2022

View reviewed changes

x/posts/types/msgs.go Outdated Show resolved Hide resolved

dadamu reviewed May 24, 2022

View reviewed changes

x/posts/keeper/posts.go Show resolved Hide resolved

dadamu reviewed May 24, 2022

View reviewed changes

x/posts/keeper/posts.go Show resolved Hide resolved

dadamu reviewed May 24, 2022

View reviewed changes

x/posts/keeper/msg_server.go Outdated Show resolved Hide resolved

dadamu reviewed May 25, 2022

View reviewed changes

x/posts/keeper/posts.go Show resolved Hide resolved

dadamu reviewed May 25, 2022

View reviewed changes

proto/desmos/posts/v1/query.proto Show resolved Hide resolved

dadamu reviewed May 25, 2022

View reviewed changes

x/posts/keeper/polls.go Show resolved Hide resolved

dadamu reviewed May 25, 2022

View reviewed changes

RiccardoM and others added 11 commits May 26, 2022 10:26

Update x/posts/keeper/subspaces_hooks.go

5eafa8a

Co-authored-by: Paul <p22626262@gmail.com>

fixed Validate comment

0e3e118

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Update x/posts/keeper/msg_server.go

75d7ab2

Co-authored-by: Paul <p22626262@gmail.com>

improved uniqueness checks

ed94516

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Merge remote-tracking branch 'origin/riccardo/posts-implementation' i…

1ae9b63

…nto riccardo/posts-implementation

removed posts events emission when deleting a subspace

99ee515

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Merge branch 'master' of github.com:desmos-labs/desmos into riccardo/…

e820a61

…posts-implementation

use string as user address instead of bytes

764f3d4

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Updated Swagger definition

2da365d

updated the ADR to be compatible with the changes

68641f2

Merge remote-tracking branch 'origin/riccardo/posts-implementation' i…

7a54d90

…nto riccardo/posts-implementation

RiccardoM requested a review from dadamu May 26, 2022 09:12

dadamu approved these changes May 26, 2022

View reviewed changes

mergify bot merged commit a091bdd into master May 26, 2022

mergify bot deleted the riccardo/posts-implementation branch May 26, 2022 10:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: ADR-010: Posts module #847

feat: ADR-010: Posts module #847

RiccardoM commented Apr 27, 2022 •

edited by dadamu

Loading

codecov bot commented Apr 27, 2022 •

edited

Loading

dadamu May 20, 2022 •

edited

Loading

RiccardoM May 26, 2022

dadamu May 25, 2022

RiccardoM May 26, 2022

dadamu left a comment

feat: ADR-010: Posts module #847

feat: ADR-010: Posts module #847

Conversation

RiccardoM commented Apr 27, 2022 • edited by dadamu Loading

Description

Author Checklist

Reviewers Checklist

codecov bot commented Apr 27, 2022 • edited Loading

Codecov Report

dadamu May 20, 2022 • edited Loading

Choose a reason for hiding this comment

RiccardoM May 26, 2022

Choose a reason for hiding this comment

dadamu May 25, 2022

Choose a reason for hiding this comment

RiccardoM May 26, 2022

Choose a reason for hiding this comment

dadamu left a comment

Choose a reason for hiding this comment

RiccardoM commented Apr 27, 2022 •

edited by dadamu

Loading

codecov bot commented Apr 27, 2022 •

edited

Loading

dadamu May 20, 2022 •

edited

Loading