feat: ADR-013: Per-chain default external address #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
x/profiles
…013-chain-default-address
…013-chain-default-address
…013-chain-default-address
Codecov Report
@@ Coverage Diff @@
## master #887 +/- ##
==========================================
+ Coverage 80.51% 80.54% +0.03%
==========================================
Files 172 172
Lines 14818 15095 +277
==========================================
+ Hits 11930 12158 +228
- Misses 2380 2415 +35
- Partials 508 522 +14
Continue to review full report at Codecov.
|
RiccardoM
changed the title
…chain-link-sim-tests
…s/desmos into paul/adr-013-chain-default-address
…s/desmos into paul/adr-013-chain-default-address
…s/desmos into paul/adr-013-chain-default-address
RiccardoM
reviewed
Jul 18, 2022
RiccardoM
reviewed
Jul 19, 2022
Co-authored-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Co-authored-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Co-authored-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Co-authored-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Co-authored-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Co-authored-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Co-authored-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Co-authored-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Co-authored-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Co-authored-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Co-authored-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
leobragaz
reviewed
Jul 19, 2022
| } | ||
| } | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Can you also add the REST endpoint inside the REST section?
…s-labs/desmos into paul/adr-013-chain-default-address
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is the implementation of chain default external address described inside #868 .
Closes: #853
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change